[jira] [Commented] (CARBONDATA-169) COLUMNDICT and ALL_DICT_PATH can not be used together

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

[jira] [Commented] (CARBONDATA-169) COLUMNDICT and ALL_DICT_PATH can not be used together

Akshay (Jira)

    [ https://issues.apache.org/jira/browse/CARBONDATA-169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15432739#comment-15432739 ]

ASF GitHub Bot commented on CARBONDATA-169:

Github user manishgupta88 commented on a diff in the pull request:

    --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/CarbonSqlParser.scala ---
    @@ -1001,6 +1001,12 @@ class CarbonSqlParser()
    +    if (options.exists(_._1.equalsIgnoreCase("COLUMNDICT")) &&
    +      options.exists(_._1.equalsIgnoreCase("ALL_DICTIONARY_PATH"))) {
    +      val errorMessage = "Error: COLUMNDICT and ALL_DICTIONARY_PATH can not be used together" +
    +        " in options"
    +      throw new MalformedCarbonCommandException(errorMessage)
    +    }
    --- End diff --
    @Jay357089 .....Move this newly added code below if loop for not isSupported check. I think ideally first we should validate the options whether they are among the ones allowed for load command and then perform other checks.

> COLUMNDICT and ALL_DICT_PATH can not be used together
> -----------------------------------------------------
>                 Key: CARBONDATA-169
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-169
>             Project: CarbonData
>          Issue Type: Bug
>            Reporter: Jay
>            Priority: Minor
> when user use "load data ... Options('COLUMNDICT'='', 'ALL_DICT_PATH'='')", the load sucess, but the query is not right.
> the reason is that columnDict and All_dict are not compatible, they should not be used together.

This message was sent by Atlassian JIRA