[GitHub] incubator-carbondata pull request #838: [CARBONDATA-974] Improve Carbon inde...

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] incubator-carbondata pull request #838: [CARBONDATA-974] Improve Carbon inde...

ravipesala-2
GitHub user kumarvishal09 opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/838

    [CARBONDATA-974] Improve Carbon index file loading file in case of big cluster

    In case of large cluster index file loading is slow as list file is getting called
    Create a index file path in code instead of list file

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kumarvishal09/incubator-carbondata BigClusterIndexLoadingTime

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/838.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #838
   
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] incubator-carbondata issue #838: [CARBONDATA-974] Improve Carbon index file ...

ravipesala-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/838
 
    Build Failed  with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1752/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] incubator-carbondata issue #838: [CARBONDATA-974] Improve Carbon index file ...

ravipesala-2
In reply to this post by ravipesala-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/838
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1753/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] incubator-carbondata pull request #838: [CARBONDATA-974] Improve Carbon inde...

ravipesala-2
In reply to this post by ravipesala-2
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/838#discussion_r112738876
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/path/CarbonTablePath.java ---
    @@ -274,6 +275,35 @@ public String getCarbonIndexFilePath(final String taskId, final String partition
               + "]");
         }
       }
    +
    +  /**
    +   * Below method will be used to get the carbon index file path
    +   * @param taskId
    +   *        task id
    +   * @param partitionId
    +   *        partition id
    +   * @param segmentId
    +   *        segment id
    +   * @param bucketNumber
    +   *        bucket number
    +   * @param timeStamp
    +   *        timestamp
    +   * @return carbon index file path
    +   */
    +  public String getCarbonIndexFilePath(String taskId, String partitionId, String segmentId,
    +      String bucketNumber, String timeStamp, ColumnarFormatVersion columnarFormatVersion) {
    +    if (ColumnarFormatVersion.V3 != columnarFormatVersion) {
    --- End diff --
   
    Better add a switch case and make V3 as default instead of strictly checking with V3 format.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] incubator-carbondata issue #838: [CARBONDATA-974] Improve Carbon index file ...

ravipesala-2
In reply to this post by ravipesala-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/838
 
    Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1756/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] incubator-carbondata pull request #838: [CARBONDATA-974] Improve Carbon inde...

ravipesala-2
In reply to this post by ravipesala-2
Github user kumarvishal09 closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/838


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] incubator-carbondata pull request #838: [CARBONDATA-974] Improve Carbon inde...

ravipesala-2
In reply to this post by ravipesala-2
GitHub user kumarvishal09 reopened a pull request:

    https://github.com/apache/incubator-carbondata/pull/838

    [CARBONDATA-974] Improve Carbon index file loading file in case of big cluster

    In case of large cluster index file loading is slow as list file is getting called
    Create a index file path in code instead of list file

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kumarvishal09/incubator-carbondata BigClusterIndexLoadingTime

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/838.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #838
   
----
commit 8aacc6f7341ab1ad042f7576bc50d8b0beb7e442
Author: kumarvishal <[hidden email]>
Date:   2017-04-21T15:12:10Z

    Improve Carbon index file loading file in case of big cluster

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] incubator-carbondata pull request #838: [CARBONDATA-974] Improve Carbon inde...

ravipesala-2
In reply to this post by ravipesala-2
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/838


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...