CarbonLock Exception refractor

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

CarbonLock Exception refractor

ZhuWilliam




Carbondata will try to lock table/column/dict when loading data. However ,for now ,it silences the exception and just return false,then tells the user "Table is locked for updation. Please try after some time" which  makes people confused. There are a lot of reasons which can make locking  fail. Maybe we should refractor here to give
users more specific error .
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: CarbonLock Exception refractor

David CaiQiang
I agree to refactor code to give detail information.
Best Regards
David Cai
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: CarbonLock Exception refractor

Venkata Gollamudi
Yes, that can be more meaningful, detailing the exception type. Any related
changes are welcome.

On Wed, Apr 12, 2017 at 4:45 PM, QiangCai <[hidden email]> wrote:

> I agree to refactor code to give detail information.
>
>
>
> --
> View this message in context: http://apache-carbondata-
> mailing-list-archive.1130556.n5.nabble.com/CarbonLock-Exception-refractor-
> tp10686p10864.html
> Sent from the Apache CarbonData Mailing List archive mailing list archive
> at Nabble.com.
>
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: CarbonLock Exception refractor

Liang Chen
Administrator
Hi William

+1 for improving CarbonLock Exception.

Do you have any proposed solution for this improvement, and can you raise one PR for it.

Regards
Liang

Venkata Gollamudi wrote
Yes, that can be more meaningful, detailing the exception type. Any related
changes are welcome.

On Wed, Apr 12, 2017 at 4:45 PM, QiangCai <[hidden email]> wrote:

> I agree to refactor code to give detail information.
>
>
>
> --
> View this message in context: http://apache-carbondata-
> mailing-list-archive.1130556.n5.nabble.com/CarbonLock-Exception-refractor-
> tp10686p10864.html
> Sent from the Apache CarbonData Mailing List archive mailing list archive
> at Nabble.com.
>
Loading...